Simplify fqns_to_feature_names in Delta Tracker #3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76432354 |
|
This pull request was exported from Phabricator. Differential Revision: D76432354 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: pytorch#3081 Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations. Existing tests passed with this logic. Differential Revision: D76432354
|
This pull request was exported from Phabricator. Differential Revision: D76432354 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: pytorch#3081 Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations. Existing tests passed with this logic. Differential Revision: D76432354
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 20, 2025
Summary: Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations. Existing tests passed with this logic. Differential Revision: D76432354
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Jun 20, 2025
Summary: Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations. Existing tests passed with this logic. Differential Revision: D76432354
|
This pull request was exported from Phabricator. Differential Revision: D76432354 |
Summary: Pull Request resolved: pytorch#3081 Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations. Existing tests passed with this logic. Differential Revision: D76432354
|
This pull request was exported from Phabricator. Differential Revision: D76432354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Each table in collection will have FQN. We can simplify the logic with this assumption to avoid two iterations.
Existing tests passed with this logic.
Differential Revision: D76432354